Include chain height when running custom decision logic #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arajasek
force-pushed
the
asr/seal-duration
branch
from
a190687 to
3eb2fa9
Compare
Codecov Report
@@ Coverage Diff @@
## master #322 +/- ##
==========================================
+ Coverage 63.62% 63.67% +0.06%
==========================================
Files 41 41
Lines 2608 2601 -7
==========================================
- Hits 1659 1656 -3
+ Misses 827 823 -4
Partials 122 122
Continue to review full report at Codecov.
|
hannahhoward
requested changes
Jul 14, 2020
| if err != nil { | ||
| return ctx.Trigger(storagemarket.ProviderEventDealRejected, xerrors.Errorf("custom deal decision logic failed to get chain head: %w", err)) | ||
| } | ||
| accept, reason, err := environment.RunCustomDecisionLogic(ctx.Context(), deal, ht) |
There was a problem hiding this comment.
Shouldn't whomever is implementing the deal decider have access to chain height on their own? We only get it from the node to begin with. My inclination would be to assume the deal decider can get access to whatever Chain APIs are needed to determine chain height.
arajasek
force-pushed
the
asr/seal-duration
branch
from
3eb2fa9 to
4383454
Compare
|
Please ignore docs-check I'm not sure why it's failing! |
hannahhoward
approved these changes
Jul 15, 2020
|
I'm not going to rush out a new release since I think your PR no longer needs this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsumed by filecoin-project/lotus#2384